Matt Martz
Matt Martz
Thanks @samdoran, I missed this PR a few weeks back. Moved a few things around, but was otherwise good to go.
Ah, I think I see. So because the output of `cat /proc/sys/kernel/random/boot_id` may be included in the output along with other data, such as `Broadcast message from...` simply using `command_result['stdout'].strip()`...
> 2\. Add parameter `ignore_netrc`/`use_netrc` for this behaviour to be more explicit. This is the solution we'll need to go with. Probably `use_netrc` with a default of `True` waiting_on_contributor
This is a backwards incompatible change fwiw.
I'm looking at a potential change in https://github.com/ansible/ansible/pull/37025 I cannot guarantee this is the fix or even that we should fix this. Te reasons are complicated, and I can try...
They do indeed. I just have a lot of testing to put in and make sure it doesn't break any other use cases. It was specifically implemented for includes such...
It has not been fixed. My PR that attempted to fix this, cannot work now, due to fundamental changes in the underlying code. In fact, I'm not sure it's feasible...
I guess maybe the 2 lines to install and enable the module are not indented far enough? https://github.com/ansible/ansible/blob/c56d98e738637a23df807bf72dd5fe6cf10a93fd/lib/ansible/modules/dnf.py#L1056-L1059
I believe the most simple solution would be to modify the `uri` module to add: ``` body = io.BytesIO(body) ``` Patch... ```diff diff --git a/lib/ansible/modules/uri.py b/lib/ansible/modules/uri.py index dd42f7eb60..01e78680e2 100644 ---...
Technically `deb` can take multiple packages, by separating the paths with a comma. But there is certainly room for improvement. ```yaml - package: name: '{{ package_files if ansible_facts.pkg_mgr != "apt"...