Matt Martz

Results 336 comments of Matt Martz

I don't know if this is the correct solution, but if anyone wants to play with this, and then if successful, submit a complete PR, be my guest: ```diff diff...

Ultimately this is a limitation of jinja2 itself. I have a script which breaks down what jinja2 does into multiple steps which you can see at https://gist.github.com/sivel/48dbc520d7d63e1ae4d819d451dd10ba Replacing `T` with...

> is there any status on if this PR will be accepted? This seems like a great feature to offer This feature has been included in the experimental fallible (https://pypi.org/project/fallible/)...

> Yes I know about that, where are you looking for feedback? In this PR or somewhere else? Feedback should be provided on the individual PRs. In this case, right...

Here is a list of related issues: Fixes: * https://github.com/ansible/ansible-builder/issues/644 * https://github.com/ansible/ansible-builder/issues/493 * https://github.com/ansible/ansible-builder/issues/472 * https://github.com/ansible/ansible-builder/issues/364 * https://github.com/ansible/ansible-builder/issues/323 * https://github.com/ansible/ansible-builder/issues/319 * https://github.com/ansible/ansible-builder/issues/201 Impacts: * https://github.com/ansible/ansible-builder/issues/562

> I wonder if the collections' requirements.txt would behave unexpectedly if it contained line continuations with backslashes @kurokobo that is correct. We discussed this when architecting the functionality, and should...

There are a few things now out of date with this PR. A few things that I know are affecting this: 1. We no longer have the copied `slugify` function...

After looking over this, let's just backport https://github.com/ansible/ansible/pull/82761 with an explicit mode.

fwiw, this is the reason that line exists: https://github.com/ansible/python-builder-image/commit/6d0d3beac1ced932e82f8838deffd8c7f3426930 > There is no epel repo for ubi8 images, so we need to make this step conditional One note, is that...