Sayan Sivakumaran comments

Results 27 comments of


                                            Sayan Sivakumaran

Should regions be flagged as requiring accessible names?

> When you require names on things that don't have an obvious name, whatever name content authors then add is likely not going to be helpful. I can see that....

Fix CVE-2022-29526 vulnerability caused by golang.org/x/sys?

Running [govulncheck](https://go.dev/doc/security/vuln/) on this library gives us the following output, so maybe this isn't a problem. ``` $ govulncheck ./... Scanning your code and 49 packages across 2 dependent modules...

width and height attributes on <table> should perhaps allow 0 as a value

So I quickly took a look at the behavior in Firefox, Chrome, and Safari, and I'm a little confused on what should be changed here, unless I'm misunderstanding something. All...

Step 2.F.iii.c doesn't say if result should be appended with or without a space

In this [Blink PR](https://github.com/chromium/chromium/commit/68243ce9b062184744635e3d75a39d429845ee7e) we decided to add whitespace around the computed name of a descendant (if it wasn't already there) if the descendant satisfied one of the following: -...

aria-disabled non-focusable descendents

Related: Should `aria-disabled` propagate to `aria-activedescendants`, even if they aren't technically focusable? For example, when playing around with [APG's Scrollable Listbox example](https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-scrollable/), I'm noticing that marking the listbox container as...

Electron: Label for grouped checkboxes isn't read when focus moves inside group

I no longer work where I did when I logged this issue. But last I checked, we did use the janky workaround described here unfortunately 🙂 > A workaround is...

folly::toJson: JSON object value was a NaN or INF

I tried naively applying a local patch to [WebSocketJSExecutor::Call()](https://github.com/microsoft/react-native-windows/blob/a21ffb63a65e621bb875ab00682f940cbfc1c4a8/vnext/Shared/Executors/WebSocketJSExecutor.cpp#L153) where I passed in the `allow_nan_inf=true` flag to the JSON serializer and ended up just getting a hang, so I guess...

Sayan Sivakumaran