postinstall-postinstall icon indicating copy to clipboard operation
postinstall-postinstall copied to clipboard

Command failed with exit code 1. (checkExecSyncError)

Open osrl opened this issue 5 years ago • 15 comments

Here is the log I get when I try to run yarn install, yarn add or node ./node_modules/postinstall-postinstall/run.js:

I've tried to debug this and I've found out that spawnSync inside checkExecSyncError returns an error. This causes checkExecSyncError to return an error also. Workaround is replacing execSync with exec.

error ****/node_modules/postinstall-postinstall: Command failed.
Exit code: 1
Command: node ./run.js
Arguments:
Directory: ****/node_modules/postinstall-postinstall
Output:
error Command failed with exit code 1.
child_process.js:660
    throw err;
    ^

Error: Command failed: yarn run postinstall
error Command failed with exit code 1.

    at checkExecSyncError (child_process.js:621:11)
    at execSync (child_process.js:657:15)
    at Object.<anonymous> (****/node_modules/postinstall-postinstall/run.js:14:5)

osrl avatar Nov 25 '19 11:11 osrl

same here

error /xxxx/react-native/node_modules/postinstall-postinstall: Command failed. Exit code: 1 Command: node ./run.js Arguments: Directory: /xxxx/react-native/node_modules/postinstall-postinstall Output: error Command failed with exit code 1. child_process.js:669 throw err; ^

Error: Command failed: yarn run postinstall error Command failed with exit code 1.`

at checkExecSyncError (child_process.js:629:11)
at execSync (child_process.js:666:13)
at Object.<anonymous> (/xxxx/react-native/node_modules/postinstall-postinstall/run.js:15:5)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)

Using yarn 1.22.4 node v10.20.1

wildanzulkarnaen avatar Apr 28 '20 13:04 wildanzulkarnaen

@ds300 Hi there, sorry for waking you up, this is currently causing us a little headache - is there anything you can do about it?

It's pretty difficult for us to patch it without having to maintain our own version of the package (since any patches using the patch-package dependency rely on this package).

welljsjs avatar Aug 27 '20 13:08 welljsjs

@welljsjs - is https://github.com/simply-vat/postinstall-postinstall a stable fix?

2xAA avatar Feb 17 '21 08:02 2xAA

It's fixed the issue for us @2xAA and we haven't had any problems with it IIRC this is the important change: https://github.com/simply-vat/postinstall-postinstall/commit/59b0064272e72ab62eab205d6c63e7e60495b097#diff-f37164ed621e6f1db870a6fa99420258869ae02f4e9d0a3de9e75a5d7910065cR4

welljsjs avatar Feb 17 '21 10:02 welljsjs

@ds300 it's hurting our project as well, please take a look if you'll have a chance

s0ber avatar May 10 '21 11:05 s0ber

@ds300 it would be great if this issue could get fixed. We've been using patch-package without issue on Linux, but it's failing for us on Windows.

It's sort of strange that postinstall-postinstall is neglected when your wildly popular patch-package depends on it. Now I'm not sure how to proceed.

Nantris avatar Nov 11 '22 03:11 Nantris

@ds300 friendly bump - the changes look very minimal - just changing require('child_process').execSync to require('child_process').exec I would submit a PR if you can confirm your willingness to accept it.

https://github.com/simply-vat/postinstall-postinstall/commit/59b0064272e72ab62eab205d6c63e7e60495b097#diff-f37164ed621e6f1db870a6fa99420258869ae02f4e9d0a3de9e75a5d7910065cR4

Nantris avatar Nov 15 '22 22:11 Nantris

@Slapbox @junipera, using exec succeeds because exec requires callback, it is async. You just ignore error and output when changing to exec. Also you break shouldUseYarn function as it will succeed every time.

Reeywhaar avatar Aug 11 '23 11:08 Reeywhaar

It seems like the real error is being swallowed for some reason. When I got this error running patch-packages in our CI, it was because a patch failed to be applied as the patch was considered invalid.

Fixing the patch error also fixed this error.

sivakusayan avatar Sep 21 '23 20:09 sivakusayan

@sivakusayan are you still seeing this with 8.x? I don't recall having seen this for some time now.

Nantris avatar Sep 21 '23 21:09 Nantris

@Slapbox I never got this problem locally, only when running the package in some Linux box for our CI (that I'm admittedly not too familiar with the set up for).

It happened when we upgraded to Node 18, along with bumping the versions of a bunch of dependencies.

sivakusayan avatar Sep 21 '23 21:09 sivakusayan

I was having the same issue, but it was caused by some no longer needed patch files, that I forgot to remove.

karel-suchomel-ed avatar Oct 17 '23 19:10 karel-suchomel-ed

What's the latest with this issue? Is there a recommended approach to getting around it?

The above fork seems to now be deprecated: https://github.com/simply-vat/postinstall-postinstall

ianyoung avatar Jan 16 '24 00:01 ianyoung

@Slapbox I never got this problem locally, only when running the package in some Linux box for our CI (that I'm admittedly not too familiar with the set up for).

It happened when we upgraded to Node 18, along with bumping the versions of a bunch of dependencies.

Were you able to resolve it? We're having the same problem after upgrading Node to 18 (from 16). The postinstall fails only in CI however sometimes it succeeds and sometimes fails. Strange.

rada avatar Jan 22 '24 11:01 rada

For me it was also an issue as part of the CI/CD process running Node.js 18.

It looks like this package has long been abandoned with no notable activity in 5+ years and this issue open for since 2019. I was lucky to be able to patch the issue I needed postinstall for at source but for other cases I would suggest using another package.

ianyoung avatar Jan 22 '24 15:01 ianyoung