Situ Chandra Shil
Situ Chandra Shil
@techievivek kind bump https://github.com/Expensify/App/issues/49448#issuecomment-2372636151
@RachCHopkins I noticed weird behavior while following steps in OP. - Please check 32s-34s in this video. First name / Last name input modal briefly appears and disappears. https://github.com/user-attachments/assets/f7c454b5-9345-4c15-a730-5f4e2a3010d1 -...
I also reproduced following the same steps in OP. https://github.com/user-attachments/assets/fb21a521-e126-4538-81d4-79fe6d71cf1e Please assign me as C+
@Burhan-Rashid thanks for the proposal. Your RCA is not correct. Auto focus logic is already [here](https://github.com/Expensify/App/blob/23b260f9593f38d9cf42bf47f4a96dcaa09a5d95/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx#L52). ---- Awaiting proposals
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...
@dominictb I am not able to reproduce original bug anymore on staging. Can you?
reproduced on main. Not reproducible on staging maybe because `canUseP2PDistance` is not enabled. Still I think we should apply logic in this PR only when `canUseP2PDistance` is enabled, to avoid...
> @situchan that's a bit redundant no? In here > > https://github.com/Expensify/App/blob/eb8b251e6874019aa2a553b96bcc8b93eedc164b/src/components/MoneyRequestConfirmationListFooter.tsx#L341-L352 > > we only use the `distance` value if the `canUseP2PDistanceRequest` flag is `true`. We also use distance...
@dominictb here's full reproduction video: (Tip: do the actions very quickly, slower network if possible) (canUseP2PDistanceRequest = true) https://github.com/Expensify/App/assets/108292595/76f16969-6f33-4335-8bc7-2dbcb2b17001