[$250] Login - First name is focused but keypad is not shown during onboarding
If you havenβt already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9.2.41-4 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1591/folder/13176677/43685627/983215890 Email or phone of affected tester (no customers): Slottwo1 [email protected] Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Other
Action Performed:
- Go to staging.expensify.com
- Select manage expenses 10 plus employees
- Enter a mail id eg : [email protected]
- Tap Get started
- Tap join
Expected Result:
First name is focused so keypad must be shown.
Actual Result:
First name is focused but keypad is not shown during onboarding.
Workaround:
Unknown
Platforms:
- [ ] Android: App
- [x] Android: mWeb Chrome
- [ ] iOS: App
- [ ] iOS: mWeb Safari
- [ ] iOS: mWeb Chrome
- [ ] Windows: Chrome
- [ ] MacOS: Chrome / Safari
- [ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/82d482c2-2d43-45b5-9412-ac697ca8badb
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021986252835445724212
- Upwork Job ID: 1986252835445724212
- Last Price Increase: 2025-12-25
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @situchan
Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Okay, I couldn't reproduce - it didn't ask me my name (only company email, which I skipped), and I didn't have any occasion to type.
Started again with a new email address and didn't get any onboarding. The add company email feature partially appeared and then disappeared before I could interact with it.
Started a third time with a new email address and got the same onboarding - this time I started adding a company email and the keyboard was there. Again, I was never asked for my name.
@jponikarchuk can we verify the repro steps/prerequisites please?
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
@RachCHopkins I noticed weird behavior while following steps in OP.
- Please check 32s-34s in this video. First name / Last name input modal briefly appears and disappears.
https://github.com/user-attachments/assets/f7c454b5-9345-4c15-a730-5f4e2a3010d1
- Another case with new gmail. (around 00:58-01:05 in video) Work email input modal briefly appears and disappears.
https://github.com/user-attachments/assets/1e698e28-98d0-4026-88ac-4d966046c605
Maybe same root cause. I think we should fix this as critical bug.
Tested on latest staging v9.2.43-0
@RachCHopkins Issue is still reproducible according to same steps. Did you start on staging.expensify.com, not on staging.new.expensify.com?
https://github.com/user-attachments/assets/1544c76f-3f9f-43b9-a38f-0e0bf3151b48
I also reproduced following the same steps in OP.
https://github.com/user-attachments/assets/fb21a521-e126-4538-81d4-79fe6d71cf1e
Please assign me as C+
I sure did @jponikarchuk but since @situchan can repro, I'll go with that.
Job added to Upwork: https://www.upwork.com/jobs/~021986252835445724212
Current assignee @situchan is eligible for the External assigner, not assigning anyone new.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Login - First name is focused but keypad is not shown during onboarding
What is the root cause of that problem?
We are not passing the autoFocus prop to the inputwrapper here: https://github.com/Expensify/App/blob/3937a1151f6a8ebaae7b3de4768080ce4504f81a/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx#L195-L206 which might cause the keyboard not opening because the input has already got the focus before the proper navigation has happened.
What changes do you think we should make in order to solve the problem?
We need to add autoFocus prop to the input wrapper here: https://github.com/Expensify/App/blob/3937a1151f6a8ebaae7b3de4768080ce4504f81a/src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx#L195-L206
<InputWrapper
autoFocus
....
What alternative solutions did you explore? (Optional)
We could also use useFocusAfterNav hook to handle this just like we are doing it at other places:
const autoFocus = useFocusAfterNav(inputCallbackRef);
...
<InputWrapper
autoFocus
....
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
@Burhan-Rashid thanks for the proposal. Your RCA is not correct. Auto focus logic is already here.
Awaiting proposals
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
@RachCHopkins @situchan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
This issue has not been updated in over 14 days. @RachCHopkins, @situchan eroding to Weekly issue.
@RachCHopkins @situchan this issue is now 4 weeks old, please consider:
- Finding a contributor to fix the bug
- Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
- If you have any questions, don't hesitate to start a discussion in #expensify-open-source
Thanks!
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Awaiting proposals
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ
Issue not reproducible during KI retests. (First week)
π£ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? πΈ