Situ Chandra Shil
Situ Chandra Shil
Please resolve conflict
reviewing Edit: actually, this is on hold for 2 issues.
yes, please remove HOLD from title.
This is feature request but not dib issue. I recommend @dukenv0307 since they provided the most accurate solution than others. Proposal: https://github.com/Expensify/App/issues/37152#issuecomment-1964336610 🎀 👀 🎀 C+ reviewed
Please reassign as I am going on vacation
> @situchan can you give us an ETA on reviewing this PR please? ETA end of day
And at least one platform screenshot with Spanish tested. And also screenshot of invite email
@trjExpensify we have Spanish message in production. So now this should be unlocalized? https://github.com/Expensify/App/blob/0cb701c34ccb45a10227f8d2e34cecab5b80cfc4/src/languages/es.ts#L2003-L2004
> @situchan @trjExpensify If we decide to remove welcomeNote, should we remove all welcomeNotes from the en and es files and then move welcomeNote to the const file? I don't...
proposals are in review