bech32 icon indicating copy to clipboard operation
bech32 copied to clipboard

QR code comparison

Open romanornr opened this issue 7 years ago • 7 comments

Hi Pieter,

I got asked to add the QR code comparison. I noticed you cleaned your git repo history up.

I couldn't make a pull request because of it. But can you do a git cherry pick? https://github.com/romanornr/bech32/commit/408c7be64a7b3e78ca6855ea12c28deee246c69f

x-screenshot from 2017-03-21 21-11-08

romanornr avatar Mar 21 '17 20:03 romanornr

Hmm, would there be a way to generate these on the fly? The size of the QR code will depend on the address type.

sipa avatar Mar 21 '17 20:03 sipa

Thinking more about it, it's a bit more complicated as you can't just convert a segwit address to an old-style address. I'll add an extra box for encoding, which lets you enter a pubkey or a script, and constructs the P2PKH/P2WPKH or P2SH/P2WSH address for it, as well as the QR code for it.

sipa avatar Mar 21 '17 20:03 sipa

Oh I see. Drak asked me, but he gave these images. So what you want is generating QR codes and showing that on the demo page ?

romanornr avatar Mar 21 '17 21:03 romanornr

@romanornr Right, but I'll do the work of generating addresses first - something the current JS code does not support.

sipa avatar Mar 21 '17 21:03 sipa

It probably doesn't work this way?

hmmmseg

romanornr avatar Mar 21 '17 21:03 romanornr

Checking in

P33LLo avatar Jan 26 '18 23:01 P33LLo

Hello me

Tawat99 avatar Sep 16 '18 17:09 Tawat99