bech32 icon indicating copy to clipboard operation
bech32 copied to clipboard

update rust reference code for bech32m

Open apoelstra opened this issue 4 years ago • 6 comments

Also add support for "bcrt" HRP

apoelstra avatar Aug 04 '21 17:08 apoelstra

Hmm, is it desirable to restrict the code to bc/bcrt/tb? I don't think the other reference code does that.

sipa avatar Aug 04 '21 18:08 sipa

If not I'm happy to remove it. It seemed like an odd thing to do, but the existing Rust code did it.

apoelstra avatar Aug 05 '21 21:08 apoelstra

Yeah, I think I'd prefer removing that requirement.

sipa avatar Aug 25 '21 13:08 sipa

Removed. This did mean that we had to remove a couple test vectors (which are "invalid segwit addresses" according to BIP-173 and 350 but nonetheless valid bech32).

apoelstra avatar Aug 25 '21 16:08 apoelstra