simurai
simurai
When having a button on the right, it's necessary to add `flex-1` (or use another approach) to make the `flash` component more responsive. Ideally, that shouldn't be needed. See https://github.com/github/github/pull/191112#discussion_r700540770
Some more issues [reported](https://github.slack.com/archives/CPA865D9S/p1632942921026100) by @edokoa: --- - The banner seems tall, but that’s default flash flash-error (I also agree that the top and bottom margins look big, but they’re...
Currently notifications use a customized `flash` alert:  Maybe one of the reasons that it needs to be customized is that the spacing of multiple `flash-action` buttons has a too...
When a flash alert has an icon and long text, the wrapping looks off. Reported in [Slack](https://github.slack.com/archives/CSGAVNZ19/p1645462338995239) 
Primer CSS currently uses this font-stack: https://github.com/primer/css/blob/40d508db292f554977b8aaf04f82af938ad9e164/src/support/variables/typography.scss#L35 Based on [this comment](https://bugzilla.mozilla.org/show_bug.cgi?id=553580#c22) it looks like Firefox on Fedora 33 does the following: - `-apple-system` skip - `BlinkMacSystemFont` skip - `Segoe UI`...
> I'd replace Helvetica with "Helvetica Neue" Yeah, we could give that a try. Although I think the problem of this issue is that if `Helvetica` is added to the...
> Why prioritise system-ui over ui-sans-serif? If the system is using, say, a serif font as the system font, would Primer really want to use that? AFAIK, Primer tries to...
@nikwen Thanks for all the testing. 🙇 Hmm.. based this test, I would say ``` font-family: -apple-system, Segoe UI, system-ui, ui-sans-serif, sans-serif; ``` that uses `Cantarell Regular` seems the best...
**Update**: This issue still needs fixing. We tried with https://github.com/primer/css/pull/1529, but that needed another change https://github.com/primer/css/pull/1573 that caused other problems... so both PRs got reverted with https://github.com/primer/css/pull/1592. ## Next steps...
> How do you feel about merging this component and start testing it out in production? Is there already a need for this in production? I think the main reason...