simurai

Results 143 comments of simurai

Thanks for the report. I think it used to work initially when the docs were `.md` files, but later the documentation for components was moved to be part of the...

> Are we removing the `Attach files by dragging ...` hint below the input? Yes, that's the plan. It's a bit risky because it helps new users discover that feature,...

> @vdepizzol * I think icon buttons have a more subtler color other than `fg.default`? Was wondering about that too for `ActionBar` in [this comment](https://www.figma.com/file/8OhcIX3PzcVhmDwSHnzwMj?node-id=97:14854#260899075). > Right. In `.btn-octicon` we...

> @vdepizzol * We probably need to confirm the padding around the icons to make sure there's enough touch area. [Particularly in the narrow representation](https://github.com/github/design/discussions/110). This probably means 8px of...

Gonna merge this as is since we're already testing the `CommentBox` in a [prototype](https://github.com/github/primer/discussions/1313) and the [Primer Web](https://www.figma.com/file/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=17091%3A66640) implementation is published. There will likely be follow-up changes in the future.

> Is there any plans to reintroduce `system-ui` back into the GitHub font stack? It has been a year since we [tried last time](https://github.com/primer/css/issues/1209#issuecomment-918704390), but so far it's still in...

New short term idea from @vdepizzol: Add `Noto Sans` to the [font stack](https://github.com/primer/css/blob/6cf2c06b4d9b72299c1fb9577020d0c8c55f8eee/src/support/variables/typography.scss#L35) just after `Segoe UI`. Apparently `Noto Sans` should be installed by default on most Linux distros and...

**Update**: `Noto Sans` is now part of the font-stack that is used on github.com. @nikwen Let us know if that improved the alignment issues you were seeing. 🙇

When testing the example with a `.js` file, the highlighting looks a bit different: No yellow brackets. `product` is not blue. Although the `name` is blue. When enabling the "Developer:...