Simon P. Couch

Transition from helpers for constructing condition messages

1

`log_problems()`, `tune_log()`, `siren()`, `message_wrap()`, and `format_msg()` currently take care of stateless (i.e. no machinery keeping track of previously seen conditions) logging in tune. We should: 1) clarify the difference between...

The `symbol.R` file contains some functionality for custom logging colors: https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/symbol.R#L19-L24 Initiated in `.onLoad()`: https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/zzz.R#L38-L39 In the time since this code written, cli has matured greatly. I'd urge us to...

Generally, the naming pattern for objects in `tune_grid_loop_iter()` follows `out_*` for objects that will be outputted and `iter_*` for internal objects. There are several exceptions, though: https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/grid_code_paths.R#L320-L321 https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/grid_code_paths.R#L354 https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/grid_code_paths.R#L410 https://github.com/tidymodels/tune/blob/f6300b1e2f3c97ef2a4f48e2aa62b8c64cb238ac/R/grid_code_paths.R#L388-L390

PR 3/3, closes #652. Follows up on tidymodels/parsnip#955 and tidymodels/workflows#199. ``` r library(tidymodels) library(propensity) propensity_wf % fit_resamples( outcome_wf, resamples = ., control = control_resamples(extract = tidy) ) res_tm %>% collect_extracts()...

first pass at postprocessing proof-of-concept

4

Mostly just pattern-matches `recipe` and `model_fit` implementations and hooks into the existing post-processing infrastructure. See tests for up-to-date examples. Previous PR description, outdated A fast and loose proof-of-concept for integrating...

I believe those in https://github.com/tidymodels/workflows/blob/1413997d256cb0e4206211f5875615434317be85/vignettes/extras/getting-started.Rmd and the hex logo are the only images needing it. See https://posit.co/blog/knitr-fig-alt/ for examples.

`use_standalone("r-lib/rlang", "types-check")` instead of home grown argument checkers

PR 2/3 to address tidymodels/tune#652. Follows up on tidymodels/parsnip#955.

consider relocating tests for `tune_args()` and `tunable()`

2

> As an additional comment... there are tests for `tune_args()` and `tunable()` methods in extratests: > - https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tune_args.R > - https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tunable.R > > do you think it's worth consolidating them...

The extras vetiver deck uses the taxi data but is situated as extra material for Advanced tidymodels, which only uses the hotel data. https://github.com/tidymodels/workshops/blob/dfa6d91289f2db4fdaab6a569720bc760ab72880/slides/extras-vetiver.qmd#L3 https://github.com/tidymodels/workshops/blob/dfa6d91289f2db4fdaab6a569720bc760ab72880/slides/extras-vetiver.qmd#L46