workflows icon indicating copy to clipboard operation
workflows copied to clipboard

consider relocating tests for `tune_args()` and `tunable()`

Open simonpcouch opened this issue 2 years ago • 2 comments

As an additional comment... there are tests for tune_args() and tunable() methods in extratests:

  • https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tune_args.R
  • https://github.com/tidymodels/extratests/blob/main/tests/testthat/test-tunable.R

do you think it's worth consolidating them with the tests here?

Originally posted by @hfrick in https://github.com/tidymodels/workflows/pull/193#pullrequestreview-1301528785

simonpcouch avatar Feb 16 '23 15:02 simonpcouch

I think they are fine here because you only need workflows Imports/Suggests to test them and they are specific to workflows itself

DavisVaughan avatar Feb 16 '23 16:02 DavisVaughan

I think we needed the tests to be in extratests during the transition period of the various methods (or at least it was easier). I meant more "moving tests into workflows" rather than the other direction - if there's anything in those tests in extratests that isn't covered here already.

hfrick avatar Feb 20 '23 14:02 hfrick