Simon P. Couch
Simon P. Couch
In many places in rsample, the package name is written "`rsample`" rather than "rsample" (i.e. there are backticks before and after the package name). Per [tidy style](https://style.tidyverse.org/index.html), package names don't...
``` r library(multilevelmod) #> Loading required package: parsnip mtcars$vs Error in terms.formula(f, specials = "id_var"): '.' in formula and no 'data' argument ``` Created on 2024-05-26 with [reprex v2.1.0](https://reprex.tidyverse.org) This...
Prepare for release: * [x] `git pull` * [x] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_stacks.html) * [x] [Polish NEWS](https://style.tidyverse.org/news.html#news-release) * [x] `urlchecker::url_check()` * [x] `devtools::build_readme()` * [x] `devtools::check(remote = TRUE, manual...
In many places in stacks, the package name is written "`stacks`" rather than "stacks" (i.e. there are backticks before and after). Per [tidy style](https://style.tidyverse.org/index.html), package names don't need backticks. Here's...
The way that `method` ought to be specified might require revisiting. Currently: https://github.com/tidymodels/workflows/blob/9e6ca982f8cd381cf4601cceb64f5ad323737476/R/post-action-tailor.R#L25-L31 This forefronts pieces of the API (classes of rsample objects) that are not user-facing for most users...
workflows rewrites print methods for each of its stage for printing. We should revisit why this is the case, and either 1) document in a code comment why it is...
We can likely rework this: https://github.com/tidymodels/workflows/blob/9e6ca982f8cd381cf4601cceb64f5ad323737476/R/predict.R#L69-L72
re: https://github.com/tidymodels/workflows/blob/9e6ca982f8cd381cf4601cceb64f5ad323737476/R/fit.R#L69-L81 Should one be able to fit a workflow by itself without specifying these two? tune can handle `method` and `prop` in a principled way internally since it has...
re: https://github.com/tidymodels/workflows/blob/9e6ca982f8cd381cf4601cceb64f5ad323737476/R/post-action-tailor.R#L128-L135 In the PR thread: > [ec0effa](https://github.com/tidymodels/workflows/pull/225/commits/ec0effa0a8e9d46faefb3616b65bae3599e0620a) surfaces an important point; removing/updating a postprocessor from an otherwise trained workflow need not remove the preprocessor and model fits, as they...
From Hannah in the linked discussion: Okay so here are my thoughts on what plumbing post-processing for survival analysis would need. Basic assumptions - We might tailor both predictions of...