Simon P. Couch
Simon P. Couch
Closes #1201. Don't love the `paste0()` smell but seems the substitution of a string that _also_ contains a substitution is a no-go.
Some `""` that don't appear to need to be there. https://github.com/tidymodels/parsnip/blob/45624583a7c6c4cfc7839c8dad3752f9ac5ff1ce/tests/testthat/_snaps/re_registration.md?plain=1#L3-L10 Noticed this in the transition to snapshot testing in #1190.
Not sure that this was the original intent of the test: https://github.com/tidymodels/parsnip/blob/45624583a7c6c4cfc7839c8dad3752f9ac5ff1ce/tests/testthat/_snaps/boost_tree_xgboost.md?plain=1#L3-L7 Noticed this in the transition to snapshot testing in #1190.
There's a good bit of this throughout the source: https://github.com/tidymodels/parsnip/blob/8af5ddf29afc17272d6768785423cf391e2685c8/R/predict_raw.R#L18-L21 A couple thoughts: 1) This warning likely ought to be an error. 2) We can set `parent = object$fit` so...
> _should this note how many levels it had? and what there were_ _Originally posted by @EmilHvitfeldt in https://github.com/tidymodels/parsnip/pull/1162#discussion_r1735214483_ This maybe ought to be a call to `check_outcome()`.
Closes #357!
Opening in favor of https://github.com/tidymodels/tailor/issues/7. A few tailor adjustments register call info for dials functions that don't yet exist: * `adjust_equivocal_zone()`: `buffer()` * `adjust_numeric_range()`: `lower_limit()`, `upper_limit()` `adjust_probability_threshold()` references `threshold()`, which...
[tailor](https://tailor.tidymodels.org/) is a new (though not yet on CRAN) package from tidymodels that implements objects specifying postprocessing steps (analogous to recipes for preprocessing). Once that package is on CRAN, I'd...
Noticed while working on emlwr the other day that `bonsai::train_lightgbm()` is quite a bit slower than `lightgbm::lgb.train()`, probably due to the handling of categorical variables / conversion to `lgb.Dataset`. Observed...