Simon P. Couch
Simon P. Couch
Awesome, glad to hear it!
Opted instead to introduce a light wrapper around `glue::glue:collapse`, which is already an Imports: ``` r parsnip:::combine_words(1) #> [1] "1" parsnip:::combine_words(1:2) #> [1] "1 and 2" parsnip:::combine_words(1:3) #> [1] "1,...
Thanks for making this happen, @qiushiyan! Feel free to mark this PR as ready for review when you feel good about it and I'll take a look. I had wondered...
Awesome, thanks for making this happen @qiushiyan. Will review and move this along next week. :)
Splitting this PR into two, one for code style edits and one to improve messaging for missing implementations. This one is now the former, so will go ahead and merge!
Thank you for reporting this! I'll put in a PR to fix this in a moment. :)
Requesting your review here, @EmilHvitfeldt, since this messaging is relevant to tidyclust, but no worries on reviewing this before the end of your vacation! These changes won't be merged until...
Looping in @topepo before merging here. See Emil's comment above—does it make more sense to just drop the second bit of the prompt entirely? Or should we think about subclassing...
Would be great to have this one in before the next release, @topepo!
Will leave to you to merge, @hfrick!