Simon P. Couch
Simon P. Couch
Thanks for the PR! I'm seeing ``` ── Error ('test-survival-survfit.R:30:3'): tidy.survfit ──────────────────────── Error in `data.frame(time = x$time, n.risk = c(x$n.risk), n.event = c(x$n.event), n.censor = c(x$n.censor), estimate = c(x$pstate), std.error...
Alright, got it. Thanks again for putting this together! After sitting with this for a bit, I think our best move here is to better document the current output. While...
A `type` argument that proxies whether output mirrors the object structure of the model object or its summary feels to me like a workaround to not just newly adding a...
Some additional context at https://github.com/tidymodels/broom/issues/1161#issuecomment-1577284354. :)
Related to #503, #197. :)
After spending more time with this, I think our best approach here will to wait for more machinery from mlr3 folks before implementing anything more principled. Prediction in a new...
Look for the fitted model object slot, these should wrap like caret or parsnip.
Feels worth mentioning that the [Value documentation for each bundle method](https://rstudio.github.io/bundle/reference/bundle_workflows.html#value) states: > The output of [unbundle()](https://rstudio.github.io/bundle/reference/bundle.html) is a model object that is ready to [predict()](https://rdrr.io/r/stats/predict.html) on new data, and...
Wonderful, this is a great start! I just approved running GHA—the failures with snap changes are unrelated to this PR and you are welcome to ignore. Could you add some...
If you're interesting in testing this against our CI, I've just approved workflows. They will fail as-is, but merging upstream should resolve any issues not due to this PR. :)...