Simon P. Couch comments

Results 165 comments of


                                            Simon P. Couch

revisiting `tunable()` for model specifications

`extract_parameter_set_dials()` tests fail because they expect anything marked with `tune()` to appear in `tunable()` output. Next steps would be to: * Fill out the `component_id()` column in `tune_args()` instead of...

Idea: move `check_args()` up into `new_model_spec()`

Very much agreed on the linked issue that we can do a better job checking arguments in `check_args()`. I think it's important to note here that the pattern in `check_args()`...

Idea: move `check_args()` up into `new_model_spec()`

Given the implications for data descriptors, I'm going to go ahead and close. Still very much on board for #1095. :)

`tunable.model_spec()` includes rows for non-tunable arguments marked with `tune()`

Okay, a few more notes here. It seems like the architecture here is: 1) `tunable()` gets called on a `boost_tree()` model spec (or other model type) 2) `tunable.boost_tree()` kicks in...

Unused arguement error while tuning

Just confirmed that this issue is fixed in the developmental version of the package via #52. For now, you'll need to install the developmental version of the package with `pak::pak("tidymodels/agua")`...