Simone Silvestri

`Similarity_theory = coupled_model.fluxes.turbulent`?

1

I am a bit puzzled by having ```julia similarity_theory = coupled_model.fluxes.turbulent ``` in this line https://github.com/CliMA/ClimaOcean.jl/blob/0cbb8a57838fbf2a11ed9991a1da2c21e487e131/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl#L32 For me is a bit counterintuitive because `turbulent` can be a lot of things...

Documentation does not build on main

5

Apparently, the documentation does not build on the main, but only on PRs when adding the `Run Example` label. These are the steps in the buildkite settings ``` steps: -...

Performance regression

4

A performance regression occurred between some commits of PR#104. This commit ran in 4hr51 https://buildkite.com/clima/climaocean-examples/builds/103#_ while the latest one takes 5hr46 https://buildkite.com/clima/climaocean-examples/builds/200 Quite some change in performance. I think this...

Handling active and passive tracers in `ocean_simulation`

8

PR #123 introduces a keyword argument `tracers` to pass to `ocean_simulation`. There are some nuances in passing this keyword argument that would be nice to discuss. In particular, the decision...

Parameter Space error

26

Our fluxes computation requires a lot of parameter space and fails on older GPUs when using a tripolar grid. MWE: using both `Oceananigans#main` and `OrthogonalSphericalShellGrids#main` ```julia using Oceananigans using ClimaOcean...

Open halo filling on Windowed fields

3

Should close #3833. Probably, we can wait to merge #3792 before this one and add some tests for fill halo regions here

`static_column_depth` interface

8

This PR introduces an interface for `column_height` that returns the height of the water column. This is simply `grid.Lz` in regular grids. For `AbstractGridFittedBottom` immersed grids, the column height is...

Bugfix in `work_layout`

2

proabably because of previous refactoring

Single column grid update_state! is missing the `update_model_field_time_series!`

2

required to force the model with a field time series. This PR adds `update_model_field_time_series!` to the `update_state!` for single column grids and a test

Cannot output Windowed fields with together with standard fields

3

MWE ```julia grid = RectilinearGrid(size = (5, 5, 5), extent = (1, 1, 1)) model = HydrostaticFreeSurfaceModel(; grid) c = CenterField(grid; indices = (:, :, grid.Nz)) d = CenterField(grid) JLD2OutputWriter(model,...