ClimaOcean.jl icon indicating copy to clipboard operation
ClimaOcean.jl copied to clipboard

`Similarity_theory = coupled_model.fluxes.turbulent`?

Open simone-silvestri opened this issue 6 months ago • 1 comments

I am a bit puzzled by having

similarity_theory = coupled_model.fluxes.turbulent

in this line https://github.com/CliMA/ClimaOcean.jl/blob/0cbb8a57838fbf2a11ed9991a1da2c21e487e131/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl#L32

For me is a bit counterintuitive because turbulent can be a lot of things (for example turbulent fluxes), but similarity theory contains all the specific details to calculate the turbulent fluxes.

The question is, should we change this name to be similarity_theory also in coupled_model.fluxes? In that way, we would be a bit more straightforward.

simone-silvestri avatar Aug 19 '24 19:08 simone-silvestri