Simon Brunel

Results 80 comments of Simon Brunel

This change comes from #5891, considered as a bug fix because the "always display last tick" was reported many times as an issue and because the initial reason of its...

@cedriclombardot Please update your PR description with the requested information and check relevant items in the checklist.

I don't think it should be a dependency but instead a peer dependency, as it's done for the [luxon](https://github.com/chartjs/chartjs-adapter-luxon/blob/master/package.json#L56) and [moment](https://github.com/chartjs/chartjs-adapter-moment/blob/master/package.json#L54) adapters.

> It absolutely requires date-fns or else it would crash and have absolutely no purpose at all This also applies to the `chart.js` peer dependency. It's an adapter between these...

> I'd be interested in a reproducible case where you saw duplicated modules. I'm wondering if in the case where `date-fns` is a (strong) dependency of the adapter (as `"date-fns":...

I think a `try ... catch` here would be an important performance hit since it's called very often (I already removed exception handling for color parsing). What moment recommend as...

That's line 13791 and if Chart.js users didn't provide a format, then we still need to fallback to `moment(value)` so we can't just drop support for `moment(value)` until next major...

The only reason I'm thinking that `_listened` would be undefined is if the `beforeInit()` hook hasn't been called before `beforeUpdate()`. @kurkle do you think of any case where this can...

Thanks @kurkle! I didn't remember about this change and never updated this plugin accordingly. Is it safe to simply replace `beforeInit` by `install` without introducing breaking change? > But as...

@Karthika-08 If you still need support on your issue, please provide a CodePen (or similar) that reproduces your problem.