Simon Brunel

Results 80 comments of Simon Brunel

`QPromise` is not a `Q_OBJECT` (or `Q_GADGET`) and its methods are not compatible with JavaScript (e.g. `QPromise::then()` doesn't work with a JS function, ie. `QJSValue`). Exception handling is also different...

The major issue is accessing the current `QJSEngine` to [convert](http://doc.qt.io/qt-5/qjsengine.html#toScriptValue) the `QPromise` value into a `QJSValue`. That's fine when the promise comes from QML but exposing a Q_SLOT or Q_INVOKABLE...

WIP on the Qt side for a native JavaScript promise: https://codereview.qt-project.org/#/c/122066/

@pwuertz FYI, a C++ promise like API is under investigation for Qt 6 ([QTBUG-80908](https://bugreports.qt.io/browse/QTBUG-80908)).

Sandbox sources: [loopback-sandbox-bug-empty-id-mongodb.zip](https://github.com/strongloop/loopback-datasource-juggler/files/1629261/loopback-sandbox-bug-empty-id-mongodb.zip) (repository deleted)

@bajtos `validateAbscence` triggers an error if `blank` returns `false` (`if (!blank(this[attr])) { err() }`). IIRC, my issue was that if an empty string `id` was sent via POST (create), the...

@fahrenq it looks like this PR is much easier to review than #42 since it focuses on removing the `` restriction (1 line change). Do you need anything else to...

I agree with @Waterstraal, it's not a workaround in many cases, for example when using GitHub pages.

@Shigma we are deploying our docs [in subfolders](https://github.com/chartjs/chartjs.github.io/tree/master/docs), per version. For example, v2.8.0 is located at https://www.chartjs.org/docs/2.8.0/, with a `latest` symbolic link alias (https://www.chartjs.org/docs/latest/). Note that we are currently using...

I'm sure it works setting `base` (though maybe not with the `latest` alias), but `base` can't be hard-coded in the repository since it depends of the current branch / tag...