Simon Andrews
Simon Andrews
* Adds a `.prettierrc` file so that the default settings are applied * Extracts `rehydrateChildren` to a separate file to aid in later testing * Exports `IOptions` and `IRehydrator` for...
`index.js` of `react-from-markup` has unclear function names. The names should be improved, and - to aid in hunting down and removing unnecessary circular dependencies, and generally improve code readability -...
Add some testing utilities. In particular, a version of [`MarkupContainer`](https://github.com/simon360/react-from-markup/blob/master/docs/demos/components/MarkupContainer/MarkupContainer.js) that can be used by developers who are using the library in their project, would be handy. Need to delineate...
This library should be _thoroughly_ tested. The unit tests from `wel-ui` covered most of the two packages, but had some holes. Since this is basically a rewrite, the tests will...
There's not much detail given about how both functional and unit testing can be accomplished. Give some detail about using `ReactDOMServer` to render statically on-page, and running a rehydrator in...
Most of the types are hidden away inside `react-from-markup`. This might be fine, but should take a look to see if any of them should be exported for use in...