silundong

> I haven't really checked that the algorithm is correctly implemented, I left only comments about the code structure. I think this needs way more tests, even if they are...

> No, I don't mean RelOptRulesTests. You need something that looks like unit tests for your code, not for Calcite. For example, when you enumerate candidate plans, it would be...

@mihaibudiu @xiedeyantu @iwanttobepowerful Thank you very much for your previous review and suggestions. Please take a look.

Thanks all for the reviews and helpful suggestions !​

Thank you for your review. Regarding the D relations, in the code it is the `dedupFreeVarsNode`, which is generated by calling the `generateDedupFreeVarsNode` after decorrelating the left input of the...

Perhaps wrapping the D (`dedupFreeVarsNode`) to make it immutable after creation would be better. Did I understand you correctly? > Do you see any downsides? The current draft implements the...

Thank you! I'll continue to advance and address the comments. I should be able to complete the updates in the next few days. This PR doesn't include the enumerable implementation...

This commit completes the comments, introduces CorrelatePlus to support the condition attribute, and implements optimizations for D elimination. The test cases look good. I think the PR is now ready...

The commit includes: 1. Optimize the `HepProgram` configuration before and after general decorrelation. 2. Fix a correlation detection bug in general decorrelation based on @iwanttobepowerful finding in [CALCITE-7303](https://issues.apache.org/jira/browse/CALCITE-7303). Thanks for...

Thank you for the detailed review! I will update in the next few days.