silundong comments

Results 17 comments of


                                            silundong

[CALCITE-7031] Implement the general decorrelation algorithm (Neumann & Kemper)

This commit mainly improves code style and comments. PTAL, thank you!

[CALCITE-7031] Implement the general decorrelation algorithm (Neumann & Kemper)

Is it a good time to create a new ticket to implement LEFT MARK JOIN in the Enumerable convention? Should this PR wait for that implementation before being merged? Please...

[CALCITE-7031] Implement the general decorrelation algorithm (Neumann & Kemper)

This PR looks ready to me. Would it be possible to merge it to advance CALCITE-7315? Thank you! @mihaibudiu @asolimando @xiedeyantu

[CALCITE-7031] Implement the general decorrelation algorithm (Neumann & Kemper)

> Can you write some documentation someplace (could be JavaDoc or JIRA) about how one should proceed to replace the old decorrelator with this one? Sure, I will add some...

[CALCITE-7031] Implement the general decorrelation algorithm (Neumann & Kemper)

I've added usage notes for TopDownGeneralDecorrelator. PTAL, thank you!

[CALCITE-7327] Support IS NOT DISTINCT FROM as equi condition of hash join

If there are no other comments, I will merge this PR after 24 hours.

[CALCITE-7327] Support IS NOT DISTINCT FROM as equi condition of hash join

Thanks. I ran locally the test that failed in CI and it passed without errors. That's indeed strange.