Takeru Ohta

Hi, thank you for proposing this new feature. It seems interesting and I want to consider that deeply this or next weekend. > Would you be willing to accept a...

> My idea is to hook into the error cases, ... Sounds promising! > it has some [optimisations](https://github.com/lpil/thoas/blob/main/src/thoas_decode.erl#L10) that might be possible to use in jsone too, if you're interested....

Sorry for the late reply. Currently, there is no plan to improve the error handling code. However, I think that it's great to make it better if it's possible to...

Thanks for your investigation. It sound good 👍

You can use the `map_unknown_value` encoding option for this purpose. The following code is an example: ```erlang tuple_to_assoc_list({K, V}) when is_atom(K) -> {ok, [{K,V}]}; tuple_to_assoc_list(T) when is_tuple(T) -> L =...

> This is especially relevant to logging. For this purpose, `jsone:term_to_json_string/1` (introduced by #65) can be used I think. And it's the default value of `map_unknown_value` since v1.7.0. So, using...

An ugly point of `jsone:term_to_json_string/1` is that it always converts unknown terms to binaries. But, IMO, it's too difficult to convert unknown tuples into nicer ones than binaries without any...

> We should only convert the portions that are not translated. I agree that it would be nice. But, again, that sounds very difficult to me.

Sorry for the delayed response but what is the status of this PR? It's still marked as a draft, so are there any TODOs to make it review-ready? (maybe benchmarking?)

I see. Thanks. I starts review of this PR. > Is there a way to run the benchmark of a branch and compare it with master? There is a benchmark...