Takeru Ohta

Results 133 comments of Takeru Ohta

After considering the above possibility, it turned out that it's difficult to allow users to specify arbitrary timestamp format in the current `slog` and `sloggers` designs. However, it could be...

@lukebakken Thank you for your response. I will work on fixing this issue and submit a pull request. Writing a unit test seems challenging, but I will give it a...

@anirudhRowjee Thank you. I think you can implement this feature like the code setting hostname tag (see below). https://github.com/sile/rustracing_jaeger/blob/master/src/reporter.rs#L152-L154 ```rust if let Ok(Ok(hostname)) = hostname::get().map(|h| h.into_string()) { this.add_service_tag(Tag::new(constants::TRACER_HOSTNAME_TAG_KEY, hostname)); }...

@Sean-Der I encountered an issue with the latest commit where the video stream seems to pause for a while when the WHEP source receives a keyframe from the peer. Although...

Sorry for the lack of examples. (Real use cases can be found in the repositories of the [users of this crate]( https://crates.io/crates/bytecodec/reverse_dependencies). But, it is not helpful for new users.)...

@kjnilsson That sounds reasonable. Thank you for your comment! I have incorporated the change in commit [e6bbd1a](https://github.com/rabbitmq/ra/pull/442/commits/e6bbd1ad060d9e718027001ab686a8eb078e0eb2). Here are the current results of the repro function: ``` > repro:run(). #...

@illotum I wasn't aware of the paper. Thank you for the information!

Since `kv_filter` is a lightweight crate, I think adding it to dependencies has no problem.