Ian Stapleton Cordasco

Results 684 comments of Ian Stapleton Cordasco

The library is in feature-freeze and this is the worst way to implement this. So many users copy headers out of their Chrome inspector without knowing what they mean and...

Also we only ever get "Shame on you for not having done this sooner with the ~5m of combined time the two of you have in any give month" or...

Requests is under feature freeze which means we will not add any additional keyword arguments to the public API like this.

@cknabs the tests are failing. Did you struggle to understand why? Can you please fix them?

@cpyberry I don't understand the documentation you've added here any longer. It's vague, unclear, and roundabout. You've been given clear suggestions that you can simply apply and would get this...

There are - unfortunately - people who've been made to feel unsafe contributing on issue #3070 who have emailed me in the past to urge this not be changed in...

Can you share more details about what makes you think there was a handshake error or other TLS issue that happened here?

@metheoryt so the fact that a we timed out while in an SSL call doesn't inherently mean this is a SSL error that's being hidden. Let's look closely: ``` ReadTimeoutError:...

@metheoryt I don't believe there's a way for urllib3 or requests to produce that distinction. I could be wrong, but I think that any solution would need to take place...

@metheoryt you've only confirmed exactly what I've been saying. The exception is a `SocketTimeout`, not an `SSLError`. I really don't see why this should be an SSL exception. You haven't...