Ian Stapleton Cordasco

Results 684 comments of Ian Stapleton Cordasco

`apparent_encoding` genuinely just needs to go away. That can't be done until a major release. Once that happens, we don't need dependencies on either library

> Hopefully, this change will benefit the people who actually depend on charset detection. As I said, most people end up far more frustrated by this "feature" than helped by...

I'm fairly certain this was at one point covered in our docs. With that in mind, why is this a _bug report_? How can you expect `Request.prepare()` to do something...

Except that commonly people set these on the session and expect them to be session-level state. I think this is complicated by the fact that `Request.prepare()` is primarily used by...

If it's not already documented, I'd merge a PR with that addition.

You can remove it after the fact: ```py req = requests.Request(...) prepared = session.prepare_request(req) del prepared.headers['User-Agent'] session.send(prepared) ```

Ah, right. Unfortunately the API right now is too limited to allow us to provide a clean way around what urllib3 does by default now (where if I remember correctly...

Changing the default would definitely need to wait until 3.0.0. I'm not against having a well-reasoned (and therefore, also well-documented) default timeout parameter. I'm still pretty strongly against sessions having...

@kuraga please search _closed_ issues. There are several discussions of this. I really don't want this diversion to distract from the topic of a _default timeout_ though. So can we...

I think that we've addressed this through documentation. I don't think any of the core team is going to change the API to require a timeout and I think we've...