sideshowbarker

Thanks much for all the patches, and sorry it took me so long to get around to merging them

> No worry. Do you think you could also have a look at the [issues I reported](https://github.com/validator/validator/issues?q=is%3Aissue%20state%3Aopen%20author%3Atenzap)? Sure yeah, I will

Closing per https://github.com/validator/validator/issues/1427#issuecomment-2288353568

> For an example of how difficult the current setup makes it to analyze HTML problems, check [validator.w3.org/nu/?doc=https%3A%2F%2Fwww.ebay.com%2F](https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.ebay.com%2F) and tell how many HTML errors the page contains. Your question implies...

> [@sideshowbarker](https://github.com/sideshowbarker), what would help strengthen this case? Would you be open to a suggestion via PR? I’d be willing to review a PR for it, yeah.

I can reproduce but also when I look from the macOS Console.app crash logger, I see a somewhat different stack trace: details: macOS Console.app crash log (expand to see) ```c++...

```html Non-standard ``` What I can see so far from my rudimentary debugging is: The box for the `a` element is the `containing_block()` for the box for that `span`. I...

So what’s happening in `FormattingContext::content_box_rect_in_static_position_ancestor_coordinate_space` that leads to it hitting the assert is: 1. The `box` parameter is the `span` box, and the `ancestor_box` parameter is the `a` box. 2....

With the following patch, we don’t crash on the reduced test case in https://github.com/LadybirdBrowser/ladybird/issues/3831#issuecomment-2702767632 at least. ```diff diff --git a/Libraries/LibWeb/Layout/FormattingContext.cpp b/Libraries/LibWeb/Layout/FormattingContext.cpp index 95e574dee53..27838d00160 100644 --- a/Libraries/LibWeb/Layout/FormattingContext.cpp +++ b/Libraries/LibWeb/Layout/FormattingContext.cpp @@ -1185,6...

I should also note that the approach in that patch also doesn’t regress any existing tests in our test suite.