sideshowbarker
sideshowbarker
I’m going ahead and closing this. For one thing, I’m worried that if I were to go into the sources and mess around with this, I’m going to regress/break something...
Does anybody plan on raising a bug against the SVG spec for this?
Reproducible at https://jigsaw.w3.org/css-validator/ — so it seems we’ll need to fix this upstream in the CSS validator sources. cc @ylafon
So I’ve noticed that in line 922 of `Web::Fetch::Fetching::scheme_fetch` here: https://github.com/LadybirdBrowser/ladybird/blob/c3e69f2fc6ced035f59f3c78f54556a372d2fd14/Userland/Libraries/LibWeb/Fetch/Fetching/Fetching.cpp#L919-L926 … `request->origin().get().scheme() == "file"sv` is false — because `request->origin().get().scheme()` is actually the empty string. It seems like for `file`...
> `request->origin().get().scheme()` should really not be an empty string, if the request isn't opaque, were you able to verify that it is? I haven’t re-verified it yet. I’m away from...
> I believe you are misunderstanding a bit, the origin in this case is supposed to be the site that triggered the request. The check makes sure that you're navigating...
Duplicate of https://github.com/LadybirdBrowser/ladybird/issues/3836?
Thanks — this looks like a good fix but I need to make time to actually test it myself before merging it. If I've not gotten around to merging it...
Thanks — this looks like another good fix but I need to make time to test it. Bump me in a week or so if I've not gotten around to...
Please bump me in a week or so if I've not gotten around to merging this yet