sideshowbarker
sideshowbarker
We’re all green here now, and so I’d like to go ahead and merge this. But before that, I want to ask: Which open issues can this close out? (@pkra...
> Let me know when it's live, so I can test the fixes. Pushed to https://validator.w3.org/nu/ just now > BTW I'm at TPAC next week so might see you there....
> 1. Can you confirm if you are still experiencing this problem? Yes — the necessary steps are still missing from the spec. > 2. If so, can you link...
@Simek You should be able to import the WPT using the invocation I mentioned earlier: ``` ./Meta/WPT.sh import http://wpt.live/wai-aria/role/roles.html \ && git add Tests/LibWeb/Text/input/wpt-import/wai-aria/role/roles.html \ && git add Tests/LibWeb/Text/expected/wpt-import/wai-aria/role/roles.txt ```...
OK yeah, for debug builds, I always have `-O0` set in my environment. So I guess anybody who might have tried to reproduce #3911 wouldn’t have been able to, without...
So it’s hitting this code in `LayoutState.h:166`: ```c++ return m_static_position_rect->aligned_position_for_box_with_size(size); ``` But when it gets there, `m_static_position_rect` has no value. I guess because `set_static_position_rect` never got called as expected to...
> Cannot repro in [6f17101](https://github.com/LadybirdBrowser/ladybird/commit/6f1710121d2f0ad340470bb2ca8fb70027f82b33). It fixed itself? Some bisecting indicates it seems to have been fixed by 305a5ad30b77531a516d139162e6b5964a6ed55a. I can reproduce the crash with dc56435ecdd2a2ec354489eb2d6d8e7f8e15e1fc but not with 305a5ad30b77531a516d139162e6b5964a6ed55a....
Apologies for not having gotten around to the before, but in the meantime it’s been superseded by https://github.com/validator/validator/pull/1828 / https://github.com/validator/validator/commit/127e7342ec115e41d84655c44bb5ef5de36136a0.
> I'm not sure custom schemas work at all. I have setup a test server, no https, only http. The schema file is not even downloaded. The only error I...
> Otherwise, would you consider at least shading the Nu-specific version of Jing that currently comes as a dependency? I am not sure what you mean by “shading”. But if...