Siddharth Kshetrapal comments

Results 484 comments of


                                            Siddharth Kshetrapal

Upgrade eslint-plugin-primer-react to v8.4.0 and enable spread-props-first rule: warn

Removed `integration-tests: recommended` because now there are no changes to any src files

Fix label `for` attribute when not scoped to model

Passing over to @jonrohan who would know more about this than me

Bump puma from 6.6.1 to 7.1.0 in /demo

puma is a webserver used only in /demo: https://github.com/primer/view_components/blob/main/docs/contributors/README.md#documentation--demo-rails-app Don't think we use it for anything public facing anymore. cc @jonrohan

ActionMenu.Anchor should only accept button

@joshblack This is great, thank you for pulling this information! Super nice that there is no nesting and it's always a primer component 🎉 - Button is perfect (not sure...

Setup test coverage with vitest

Both tbh. I'd like us to have really high coverage, but no clue how far we are from that to say anything

Add primer primitives extension to recommended VSCode extensions

Added `skip github ci` because this is a dev environment only change

[ActionMenu.Button] onClick doesn't function

Hey! Can confirm that the `onClick` is overwritten. Can classify as bug. Out of curiosity, what are you planning to do in the onClick handler?

[ActionMenu.Button] onClick doesn't function

> I want to trigger a check to filter out options from the dropdown. That's interesting, can you share more? (Note: This repository is open source. If the context is...

[ActionMenu.Button] onClick doesn't function

👋 @DavidMeu, this came up in the prioritisation call today. Can I get some context around what you are working on, that will help us if we need to prioritise...

[ActionMenu.Button] onClick doesn't function

- WIP: https://github.com/primer/react/pull/4648