Siddharth Kshetrapal
Siddharth Kshetrapal
> Focus should stay where it is > By "where it is" meaning the same index, not the same item, right? For the scenario i'm mentioning here of loading more...
Hey 👋 Just checking in if this was solved, no rush!
@alondahari Sounds perfect! It's also shipped to all users now, so we can safely remove the wrapper. @francinelucca I think we need to clean up the flag on dev portal!
Sorry! `primer_react_select_panel_with_modern_action_list` is shipped for everyone (https://github.com/primer/react/pull/6339). We don't have to wrap ItemPicker with `` anymore :) @francinelucca Correct me if i'm wrong
> I believe I already removed the wrapper from [ItemPicker](https://github.com/github/github-ui/blob/700d9301298e4d1e5b64504d674aeb14a9c8c758/packages/item-picker-base/components/ItemPicker.tsx#L4) whenever we fully shipped the flag. 🙃 You already removed it for ItemPicker, that's my bad for not checking `main`
yep, let's close it. Thank you!
Leaving notes for triage - @TylerJDev made TrailingVisual accessible to screen readers in https://github.com/primer/react/pull/4666 - LeadingVisual remains aria-hidden because we always assume it's decorative, @iansan5653 do you have use cases...
It would be, however I'm not actively investing time into this project right now. Feel free to fork and extend!