Siddharth Kshetrapal

Results 484 comments of Siddharth Kshetrapal

> inactive items can still trigger actions Oh! Totally didn't expect that!

> The other thought here is that my understanding of the shape of this work is getting initial functionality in for demo purposes, and then follow up with accessibility tweaks...

Curious to hear your thoughts here @mperrotti, This PR is very specific to drag and drop behavior, which is fine, as long as we also bake-in user feedback for dragging...

> they would just show some empty space there so as to not break the tree layout (we'll only be rendering drag handles for first level items to begin with)....

> For what it's worth, I really like the idea behind leadingAction. I also wonder if we'll run into a future state where the design calls for both drag and...

Great, we have a direction then! @ayy-bc, I have an implementation in mind, I'll try to finish it tomorrow. Do you mind if I update your PR itself with the...

Pushed some changes, waiting for story to be deployed Leaving notes for myself TODOs In the story: - [x] implement fold on click - [x] implement hide until hovered TODOs...

@ericwbailey Do you know if should add an `aria-hidden` to the leading action until we know it's accessibility story? (There's no way to get to it with keyboard navigation either)

> Ultimately, we'd need it and also tabindex="-1" applied to [any interactive element](https://ui.githubapp.com/storybook/?path=%2Fdocs%2Frecipes-nestedlistview-documentation-accessibility-listitem--docs#suppression-of-secondary-info-and-actions) on the leading action to fully suppress it. If you have the capacity to sneak that in...

@mperrotti Hi 👋 Can I get a review for the snapshots?