Simon Birrer
Simon Birrer
The grid_interp_x and grid_interp_y in the lens model module is also not optimal as it requires rectangular orientation. I'd prefer not having a mix of interpolation schemes defining a coordinate...
thanks @itrharrison @ntessore . I agree that we should consistently only use one definition, and g_1, g_2 is a good choice. Feel free to close this issue.
thanks @ajshajib ! In the latest PR I just added the link and a small description. Further improvements can be made but are not strictly necessary
Hi @Maverick-Oh , just pinging you here to see whether you noticed my comment.
it's not urgent, I was just checking whether you are still on it, as I don't want PR's to die out :) all good, no rush. Thank you very much!
@ajshajib : ah, not yet. It's on my todo list and then I re-post it to Sydney. This branch currently also has conflicts that need to be resolved. Since this...
@jhod0 thanks a lot! This is super helpful. There are some tests failing in the CI. You can also test locally, e.g. >>> py.test test/test_Workflow
@KirillRnd thank you for posting this issue! What are your numba and numpy versions? This looks like an incompatible numba version, or no compiler for numba in the virtual environment....
Thanks for looking into this! The versions look up to date. My guess would be that the first laptop does not have a C compiler for numba to run (or...
Thank you for the post @amn3142 ! ah right, any light model is getting convolved for now in lenstronomy, and if there is light outside the convolution boundaries, that can...