Simon Birrer
Simon Birrer
thanks @ewoudwempe for the info (and indeed I should have remembered you have this on your fork). Nested sampling is often more time-consuming but comes with the evidence, and possibly...
> I see from the tests that the CSE itself is done through semi-major axis (in that no matter what you change e1 to, kappa_major=kappa_round in `test_cored_steep_ellipsoid.test_ellipticity()`.) This probably explains...
Thanks @mattgomer for looking into this! Indeed, the derivative scaling might be the issue. I also highly suggest re-scaling 's' such that 's' will have the meaning of the product...
Hi @ajshajib, thanks a lot for this implementation! Yes, I am happy with how you added the functions into the existing design. Perhaps one aspect to check is that you...
@ajshajib there was also a failure of CI on the main branch and if you merge with main, the tests should pass
brrr...this could either be a one-off (then we should set a random seed that it does not happen, or they have changed the settings to trigger a raise instead of...
there is one check failing resulting in nan instead of a number
ok. This PR might actually also help speed-up a bit the kinematics calculation for the milestone paper ;)
> > Hi @sibirrer, can you kindly point me to the `astropy` standard conventions for me to see what to follow. I believe, my PyCharm is set to have max...
For all imports of the classes, you can have a look here: https://github.com/sibirrer/lenstronomy/blob/master/lenstronomy/LensModel/profile_list_base.py#L55