lenstronomy icon indicating copy to clipboard operation
lenstronomy copied to clipboard

Published 20 hours ago • verified publisher icon lenstronomy

Refactor sampling parameter handling

Open jhod0 opened this issue 2 years ago • 1 comments

This PR would continue the refactor of parameter handling implemented in #350

It will reimplement the following two parameter classes with the framework in Sampling/param_group.py:

  • [x] Refactor LightParams
  • [ ] Refactor LensParams

Of course, this is low-priority. It adds no features but would hopefully ease maintenance in the future, and make it simpler to add new sampled parameters to these classes.

Just opening the PR for discussion

jhod0 avatar Aug 25 '22 15:08 jhod0

@jhod0 thanks a lot! This is super helpful. There are some tests failing in the CI. You can also test locally, e.g.

py.test test/test_Workflow

sibirrer avatar Aug 25 '22 17:08 sibirrer