Shuya Ma

Results 93 comments of Shuya Ma

> Looks reasonable. Do we already do something similar when we destroy the resource via Terraform? Do you mean how we handle destroying the resource (that destroyed outside of Terraform)...

Yeah, we only check if the delete request return errors, but could not tell if the resource still exists but in DESTROYED state.

Hi @jcanizalez, I don't think the failing test is related to this PR. Sorry for the noise! Newly added test `TestAccDialogflowConversationProfile_update` seems passed. I'll start reviewing this PR then.

Hi @jcanizalez! Sorry for the delay on this. It seems that the tests for this resource are skipped. Are you able to test it locally? Update: Sorry, nvm, just realized...

Hi @GomathiMarisamy! Thanks for filing the issue! Would you mind providing more information about this issue and also sharing your config and debug log, so that I can test and...

Thanks for sharing! Looks like you are using modules. Could you double check if those modules are up-to-date that contain the `database_dialect` field. Support for `database_dialect` was added in `v4.17.0`...

Would you mind sharing the build log for this error please. Thanks!

Note: After `allocated_ip_range` being added to `google_sql_database_instance`, the test has been renamed to `TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange` and a new test `TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange` has also been implemented. Both tests have passed since 12/04. Will...

I think it's the test set that contains tests running serially. Click the [debug log](https://console.cloud.google.com/storage/browser/ci-vcr-logs/beta/refs/heads/auto-pr-6227/artifacts/8867e193-31fe-40ad-8276-472ee62bfa38/recording), you should be able to see the test logs I think.