New Resource : google_dialogflow_conversation_profile

[jcanizalez]

Hi team,

fixes hashicorp/terraform-provider-google#12466

If this PR is for Terraform, I acknowledge that I have:

• [X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [X] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_dialogflow_conversation_profile`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 3792 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 3792 insertions(+), 2 deletions(-)) TF Validator: Diff ( 3 files changed, 1228 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2171 Passed tests 1930 Skipped tests: 236 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccDialogflowConversationProfile_update|TestAccFirebaserulesRelease_BasicRelease|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeInstance_soleTenantNodeAffinities

[modular-magician]

Tests passed during RECORDING mode: TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log] TestAccDialogflowConversationProfile_update[Debug log] TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccCGCSnippet_eventarcWorkflowsExample[Debug log]

Tests failed during RECORDING mode: TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

[jcanizalez]

hi @shuyama1 can you please share me the logs for the errors in tests? Thanks

[shuyama1]

Hi @jcanizalez, I don't think the failing test is related to this PR. Sorry for the noise! Newly added test TestAccDialogflowConversationProfile_update seems passed. I'll start reviewing this PR then.

[jcanizalez]

awesome thank you @shuyama1

[jcanizalez]

Hi @shuyama1 I hope you are doing well, did you get chance to take a look Thanks

[shuyama1]

Hi @jcanizalez! Sorry for the delay on this. It seems that the tests for this resource are skipped. Are you able to test it locally?

Update: Sorry, nvm, just realized a handwritten test is added. Please ignore this :)

[github-actions[bot]]

@jcanizalez, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@jcanizalez, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

[github-actions[bot]]

@jcanizalez, this PR is being closed due to inactivity.