magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

fix import for bigquery-data-transfer resource

Open ScottSuarez opened this issue 2 years ago • 18 comments

closes https://github.com/hashicorp/terraform-provider-google/issues/12011

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed import for `google_bigquery_data_transfer_config`

ScottSuarez avatar Jul 06 '22 19:07 ScottSuarez

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 22 insertions(+), 12 deletions(-)) Terraform Beta: Diff ( 3 files changed, 22 insertions(+), 12 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 06 '22 19:07 modular-magician

Tests analytics

Total tests: 2088 Passed tests 1858 Skipped tests: 226 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

modular-magician avatar Jul 06 '22 20:07 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 06 '22 20:07 modular-magician

@shuyama1 , any idea why the logs for TestAccBigqueryDataTransferConfig failed to upload?

ScottSuarez avatar Jul 08 '22 18:07 ScottSuarez

I think it's the test set that contains tests running serially. Click the debug log, you should be able to see the test logs I think.

shuyama1 avatar Jul 08 '22 18:07 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 08 '22 20:07 modular-magician

Tests analytics

Total tests: 2091 Passed tests 1861 Skipped tests: 226 Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease

modular-magician avatar Jul 08 '22 20:07 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 08 '22 20:07 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 08 '22 21:07 modular-magician

Tests analytics

Total tests: 2091 Passed tests 1862 Skipped tests: 226 Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

modular-magician avatar Jul 08 '22 22:07 modular-magician

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 08 '22 22:07 modular-magician

/gcbrun

ScottSuarez avatar Jul 11 '22 20:07 ScottSuarez

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Jul 11 '22 21:07 modular-magician

Tests analytics

Total tests: 2093 Passed tests 1862 Skipped tests: 226 Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled

modular-magician avatar Jul 11 '22 21:07 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[view] TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[view] TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view] TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Jul 11 '22 22:07 modular-magician

@ScottSuarez Hi, thanks for your great work. What is the current status of this PR?

kanata2 avatar Sep 06 '22 11:09 kanata2

Bump. Can we please get this merged in?

Thank you...

lodotek avatar Sep 23 '22 18:09 lodotek

There are outstanding issues with this change that need to be looked at. WIth my queue of work and priorities I haven't had time to investigate this further.

ScottSuarez avatar Sep 23 '22 21:09 ScottSuarez

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Oct 14 '22 18:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 27 insertions(+), 14 deletions(-)) Terraform Beta: Diff ( 3 files changed, 27 insertions(+), 14 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Oct 17 '22 20:10 modular-magician

Tests analytics

Total tests: 2191 Passed tests 1950 Skipped tests: 239 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigqueryDataTransferConfig|TestAccBillingSubaccount_renameOnDestroy

modular-magician avatar Oct 17 '22 21:10 modular-magician

Tests passed during RECORDING mode: TestAccBillingSubaccount_renameOnDestroy[Debug log]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Oct 17 '22 21:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 33 insertions(+), 20 deletions(-)) Terraform Beta: Diff ( 4 files changed, 33 insertions(+), 20 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Oct 17 '22 21:10 modular-magician

Tests analytics

Total tests: 2192 Passed tests 1945 Skipped tests: 239 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigqueryDataTransferConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeForwardingRule_update

modular-magician avatar Oct 17 '22 22:10 modular-magician

Tests passed during RECORDING mode: TestAccComputeRouterNat_update[Debug log] TestAccComputeRouterNat_basic[Debug log] TestAccComputeRouterNat_withPortAllocationMethods[Debug log] TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log] TestAccComputeRouterNat_removeLogConfig[Debug log] TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log] TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Oct 17 '22 22:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 36 insertions(+), 23 deletions(-)) Terraform Beta: Diff ( 4 files changed, 36 insertions(+), 23 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Oct 18 '22 17:10 modular-magician

Tests analytics

Total tests: 2193 Passed tests 1946 Skipped tests: 239 Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic

modular-magician avatar Oct 18 '22 18:10 modular-magician

Tests passed during RECORDING mode: TestAccFirebaserulesRelease_BasicRelease[Debug log] TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log] TestAccComputeRouterNat_withPortAllocationMethods[Debug log] TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log] TestAccComputeRouterNat_removeLogConfig[Debug log] TestAccComputeRouterNat_update[Debug log] TestAccComputeRouterNat_basic[Debug log]

Tests failed during RECORDING mode: TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR View the build log or the debug log for each test

modular-magician avatar Oct 18 '22 18:10 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 37 insertions(+), 24 deletions(-)) Terraform Beta: Diff ( 4 files changed, 37 insertions(+), 24 deletions(-)) TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician avatar Oct 18 '22 19:10 modular-magician

Tests analytics

Total tests: 2193 Passed tests 1952 Skipped tests: 239 Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease

modular-magician avatar Oct 18 '22 20:10 modular-magician