dalaoshu

Results 102 comments of dalaoshu

> ### type coverage contribution guide > 1. run `pnpm install` > 2. run `pnpm run type-coverage` > 3. view files with low type coverage to contribute Should we add...

> Hey @SoonIter Still relevant to increase the type coverage for some of the files mentioned? Welcome, try to do it.

Same issue in https://github.com/oxc-project/oxc/issues/8842 Small repo: https://github.com/shulaoda/repo-cases/tree/ignore-override-builder ```css . ├── src │ ├── main.rs │ └── tests │ ├── main.js │ └── ignore │ └── main.js ``` ```rust fn main()...

I’m not very familiar with the codebase, so there might be a better way to handle this.

> I think there are some possible improvements. One is: instead of `VALID_IDENTIFER: Regex` there can be a simple char parser. Perhaps we can take inspiration from https://github.com/rolldown/rolldown/pull/3677. I’ll review...

I think you should use `tsconfig: true`, the `tsconfig: '..'` behavior aligns with `esbuild`. It does not follow `references`, nor does it honor `include` or `exclude`.

Oh, I literally did the exact same thing just now! https://github.com/rust-lang/rustfmt/pull/6682 👀

@snecker Please wait for the next release, this issue has been fixed in `oxc-resolver`.

Could you provide a mini reproduction?