dalaoshu

Results 101 comments of dalaoshu

> How about validating if the regex is valid using `refine` from zod? Something like I tried it, but it doesn't seem to work on the ts side.

> Thank you for working on this. We may need ast-grep in our CI to prevent this before the clippy rule gets released. Let me research how to add it...

@Boshen cc It seems unnecessary to modify the following. ```bash crates/oxc_codegen/src/lib.rs|318 col 63| unsafe { std::str::from_utf8_unchecked(self.code()) }.chars().nth_back(n) crates/oxc_linter/src/partial_loader/astro.rs|75 col 49| if let Some('/') = self.source_text.chars().nth(js_start - 2) { crates/oxc_linter/src/rules/eslint/no_useless_escape.rs|199 col...

> @shulaoda is this a comprehensive list or are there more areas you want to document? This is not comprehensive, I will gradually supplement it. I will list the areas...

> @shulaoda I don't love having a running issue like this open without clear goals, so I'm going to close this as complete. When you find other areas you want...

I've noticed that many issues arise due to incomplete or unclear rule documentation. I will continue to improve the relevant documentation and add more detailed descriptions for the options. However,...

> Could you specify the maximum number of characters per line for the documentation comments? The line length shouldn't exceed `100` characters to maintain code readability and maintainability, optimizing the...

I checked and think this is an expected behavior. Can you double check? @DonIsaac

> In that case the rules for `eslint` and `import` groups are not working correctly :p > > As mentioned in the OP those actually do override. > > e.g....

> I will work on src/stats/StatsFactory.ts @shulaoda I am working on `src/logging/truncateArgs.ts` 👀