Jon Cluce

Results 89 comments of Jon Cluce

> I planned to add more notes after going through the default config in more detail. Lmk what you want to do. Up to you! I think we should at...

Making this a draft again after a convo w/ Greg; going to do BBR on its own first, then this configurable to 1. Do second run only on failure 2....

Not quite finished ― working on getting the short-circuit to work if we're retrying iff the first try fails

In pulling this out of https://github.com/FCP-INDI/C-PAC/pull/1789 / https://github.com/FCP-INDI/C-PAC/pull/1814, resolving merge conflicts and testing, I've discovered there's a lot of decision space in https://github.com/FCP-INDI/C-PAC/blob/e5ba0f2eeddc193ecdcc40a7f8f4156c083a98e5/CPAC/resources/configs/pipeline_config_blank.yml#L526-L545 https://github.com/FCP-INDI/C-PAC/blob/e5ba0f2eeddc193ecdcc40a7f8f4156c083a98e5/CPAC/resources/configs/pipeline_config_blank.yml#L709-L714 Is retry_on_first_failure On Off best_of 1>11...

Additional comments / updates not slated for 1.8.5: - [ ] Choice of `h5` or `nii.gz` for output transforms - [ ] Choice of `tsv` or `1D` for output timeseries...

I think we should replace our current workflow with one that uses [Delete Package Versions](https://github.com/marketplace/actions/delete-package-versions)

> Where we’re hitting the error, it’s in the `abcd` method of applying the functional registration template. Looking at the code, I think the `single_step_resampling_from_stc` and `dcan_nhp` methods will also...

A little bit of diagnosis here: I _think_ the underlying issue here is the combination of ```YAML registration_workflows: functional_registration: func_registration_to_template: apply_transform: # 'single_step_resampling': apply motion correction, func-to-anat and anat-to-template transforms...

> In https://github.com/FCP-INDI/C-PAC/blob/960305c38f611502fd7610dffd770d171a5e4b82/CPAC/func_preproc/func_preproc.py#L1207-L1229, how are the outputs "max-displacement", "rels-displacement", "movement-parameters" and "coordinate-transformation" interrelated? ― @shnizzedy > In the code snippet you provided, the outputs "max-displacement", "rels-displacement", "movement-parameters", and "coordinate-transformation" are...

Motion params: > roll = rotation about the I-S axis } > pitch = rotation about the R-L axis } degrees CCW > yaw = rotation about the A-P axis...