Shumpei Wakabayashi comments

Results 50 comments of


                                            Shumpei Wakabayashi

Can't stop before blocking obstacle in parking

@alanmengg Looks like this issue is not completed yet? If completed, it is helpful to give us the evidence.

feat(accel_brake_map_calibrator): add new Recursive Least Square method

spell miss https://github.com/autowarefoundation/autoware.universe/actions/runs/3239609749/jobs/5309193223 I fixed it by https://github.com/autowarefoundation/autoware.universe/pull/1255/commits/a39884bef566f56b863ed79c2304414606da2e19

feat(accel_brake_map_calibrator): add new Recursive Least Square method

LGTM! ![view_plot](https://user-images.githubusercontent.com/42209144/198912653-12367e2e-d8de-404e-9c14-c9c117043b71.png) [accel_map.csv](https://github.com/autowarefoundation/autoware.universe/files/9897250/accel_map.csv) [brake_map.csv](https://github.com/autowarefoundation/autoware.universe/files/9897251/brake_map.csv) (For TIER IV internal infomation) I calibrated them using the 10min rosbags (2022.10.12) from dd0a1334-760f-4ed1-84dc-9d12cf23baf5_2022-10-12-16-24-14_0.db3 to dd0a1334-760f-4ed1-84dc-9d12cf23baf5_2022-10-12-16-24-14_10.db3

waymo-open-dataset in windows?

How about [using docker](https://github.com/waymo-research/waymo-open-dataset/blob/master/pip_pkg_scripts/README.md) instead ?

docs(tutorials): add crosswalk passing scenario in tutorials page

Great work! I will leave minor comment.

docs(tutorials): add crosswalk passing scenario in tutorials page

@Ericpotato Please check spell check CI.

docs(tutorials): add crosswalk passing scenario in tutorials page

As for signalized crosswalk, when the traffic light for the car is green and there is a pedestrian on the crosswalk which intersects with the planned route, the ego will...

docs(tutorials): add crosswalk passing scenario in tutorials page

@Ericpotato Could you modify the pull request title?

feat(pull_request_templates): improve the pull request template to enhance requirements on documenting interface changes

We need [tag:run-build-and-test-differential](https://github.com/autowarefoundation/autoware.universe/labels/tag%3Arun-build-and-test-differential) to run CI.

perf(lane_change): rework object filter

The code looks good to me.