autoware.universe
autoware.universe copied to clipboard
perf(lane_change): rework object filter
Description
Lane change object filters checks for object's arc length from ego, and this time consuming process might be resource extensive if the number of object is huge.
To avoid this issue, the object filtering in lane change is improve, by first performing rough checks, by checking object current location and speed, and then remove if it is not fulfill the requirement.
The following will be the new logic for the object filtering
Related links
Tests performed
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
- [X] I've confirmed the contribution guidelines.
- [X] The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
- [ ] The PR follows the pull request guidelines.
- [ ] The PR has been properly tested.
- [ ] The PR has been reviewed by the code owners.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
- [ ] There are no open discussions or they are tracked via tickets.
- [ ] The PR is ready for merge.
After all checkboxes are checked, anyone who has write access can merge the PR.
Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6847/ Modified URLs:
- https://autowarefoundation.github.io/autoware.universe/pr-6847/planning/behavior_path_lane_change_module/
The code looks good to me.
@Owen-Liuyuxuan
Thank you for your detailed documentation. I would love to have some more local tests.
Thank you for your comments, but may I know what do you mean by some more local tests
?
@Owen-Liuyuxuan
Thank you for your detailed documentation. I would love to have some more local tests.
Thank you for your comments, but may I know what do you mean by
some more local tests
?
Sorry for the late reply, I was considering how to quantify the improvements with some current ROSBag. But I was blocked by some other tasks lately.