autoware.universe icon indicating copy to clipboard operation
autoware.universe copied to clipboard

perf(lane_change): rework object filter

Open zulfaqar-azmi-t4 opened this issue 10 months ago • 4 comments

Description

Lane change object filters checks for object's arc length from ego, and this time consuming process might be resource extensive if the number of object is huge.

To avoid this issue, the object filtering in lane change is improve, by first performing rough checks, by checking object current location and speed, and then remove if it is not fulfill the requirement.

The following will be the new logic for the object filtering

flow chart

Related links

TIER IV Internal Link

Tests performed

TIER IV Internal link

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • [ ] The PR follows the pull request guidelines.
  • [ ] The PR has been properly tested.
  • [ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [ ] There are no open discussions or they are tracked via tickets.
  • [ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

zulfaqar-azmi-t4 avatar Apr 18 '24 12:04 zulfaqar-azmi-t4

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6847/ Modified URLs:

  • https://autowarefoundation.github.io/autoware.universe/pr-6847/planning/behavior_path_lane_change_module/

github-actions[bot] avatar Apr 19 '24 09:04 github-actions[bot]

The code looks good to me.

shmpwk avatar Apr 23 '24 10:04 shmpwk

@Owen-Liuyuxuan

Thank you for your detailed documentation. I would love to have some more local tests.

Thank you for your comments, but may I know what do you mean by some more local tests?

zulfaqar-azmi-t4 avatar Apr 24 '24 08:04 zulfaqar-azmi-t4

@Owen-Liuyuxuan

Thank you for your detailed documentation. I would love to have some more local tests.

Thank you for your comments, but may I know what do you mean by some more local tests?

Sorry for the late reply, I was considering how to quantify the improvements with some current ROSBag. But I was blocked by some other tasks lately.

Owen-Liuyuxuan avatar Apr 26 '24 01:04 Owen-Liuyuxuan