Aleksey Shipilëv

Results 160 comments of Aleksey Shipilëv
trafficstars

I looked at GHA failures, and they do not look relevant to this PR. /sponsor

This one is not needed, as the block `` above handles it by enumerating which annotation processor to run explicitly.

Please do the following: 1. Inline `removeJdwpAgentLib`. 2. Enable GHA tests and pass them.

We don't really have a concrete plan to bundle hsdis, so far. It looks like Capstone comes with compatibility problems that @sxa identified above. So it looks to me we...

To emphasize, my point is that `alignment(8)` is a behavior that _someone_ likely depends on in earlier JDKs. We need to continue testing that. So `alignment(8)` should stay until the...

> Ack. Wdyt about keeping the java version check, and on newer jdks set it to 1 then? Maybe, but likely not. I could see how JDK-specific test behavior would...

Yes. We strive to test everything that users would likely end up using.