CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses

[judovana]

trafficstars

No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:

java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005  -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"

works.

---

Progress

• [x] Change must not contain extraneous whitespace
• [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• CODETOOLS-7903756: jcstress shuld not pass debugging parameters to subproceses (Bug - P4)

Reviewers

• @matcdac (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/150/head:pull/150
$ git checkout pull/150

Update a local copy of the PR:
$ git checkout pull/150
$ git pull https://git.openjdk.org/jcstress.git pull/150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 150

View PR using the GUI difftool:
$ git pr show -t 150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/150.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back jvanek! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@judovana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7903756: jcstress: Skip debugging JVM options for sub-processes

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge[bot]]

Webrevs

• 07: Full - Incremental (ad692a81)
• 06: Full - Incremental (b4c88fa1)
• 05: Full - Incremental (95556157)
• 04: Full - Incremental (2b6b3be3)
• 03: Full - Incremental (6ffc620b)
• 02: Full - Incremental (23291cb3)
• 01: Full - Incremental (41426036)
• 00: Full (5266af04)

[judovana]

Hello! Thanx a lot for review.

The https://github.com/openjdk/jcstress/pull/119 can be closed with its corresponding bug of https://bugs.openjdk.org/browse/CODETOOLS-7903266 , if we agree on merging this (#150) . I had noticed the bug and the PR only I drafted my PR. Sorry.

[judovana]

/integrate

[openjdk[bot]]

@judovana This pull request has not yet been marked as ready for integration.

[judovana]

@judovana This pull request has not yet been marked as ready for integration.

Hmm, then we need approver and sponsor?

[judovana]

/integrate

[openjdk[bot]]

@judovana This pull request has not yet been marked as ready for integration.

[judovana]

hi! Ty!

The only reason to not inline the removeJdwpAgentLib is need of comment instead of separate method. But I do not have strong preference. TYVM for eyball and GH!

[shipilev]

Please do the following:

1. Inline removeJdwpAgentLib.
2. Enable GHA tests and pass them.

[judovana]

Cool. All except MACs are green.

[judovana]

/integrate

[openjdk[bot]]

@judovana Your change (at version ad692a81db10021bfe23465f8f42235b63bb8b38) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk[bot]]

Going to push as commit 6def1a9384321534dca92e147dbe5e573c9ec601.

[openjdk[bot]]

@shipilev @judovana Pushed as commit 6def1a9384321534dca92e147dbe5e573c9ec601.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.