Brendan Forster

Results 633 comments of Brendan Forster

I don't have any recommendations, but that's mostly because I haven't tried this. What hurdles did you encounter while doing this?

@ruettenm can you tell me a bit more about your setup? - OS version - Electron version - version of `keytar` used - how the app is being signed -...

> So it looks like your library is not signed and/or notarized and in this case it's a problem when using it inside a signed and notarized app. The keytar...

@dracan keytar is about leveraging the OS for managing credentials associated with your apps, rather than rolling your own credential storage. If you want to isolate your applications credentials from...

@dracan > I just don't want any old app to be able to access those credentials. The credential stores in the OS haven't been designed with that in mind (at...

@rsese I think this comment is key, based on my understanding of the KDE ecosystem https://github.com/atom/node-keytar/issues/74#issuecomment-456153037

I'm curious about how this will look, but I worry about adding APIs that are only supported on platform: - we don't have an equivalent concept for Windows or Linux,...

We're using Ubuntu 16.04 to build the native modules because that's the oldest runner that's available with Actions: https://github.com/atom/node-keytar/blob/12484088ce0980a903627b6fc7ddaaf02188e982/.github/workflows/ci.yml#L25 With how much that's Ubuntu-specific in the CI scripts to setup...

> Can you share more info on this regard (just a curiosity though)? It's not just upgrading the OS that needs to happen here, based on when I tried this...

@aaomidi thanks for the question. I'm afraid this isn't currently supported beyond "try it and see if it errors", and hasn't really been explored in depth.