Brendan Forster

Results 633 comments of Brendan Forster

@gknapp thanks for the extra details. If you've got an isolated repro of the issue to share that'd be great, but I'd also check that your webpack configuration is pulling...

@TomasHubelbauer as a sanity check, can you confirm this works in a standalone Electron app?

@TomasHubelbauer that's on me to look at what you've provided. If I needed more from you I'd set it to `needs-more-information`.

@TomasHubelbauer apologies for the delay in replying. I had a look at your reproduction and realised it wasn't quite testing some important cases: - it assumes the module loading worked...

> If there is anything I can do to try and further research into this, please, let me know. :-) I'm kind of stumped myself about the next steps, and...

I believe that this behaviour is related to this line inside `setPassword`: https://github.com/atom/node-keytar/blob/fd66226fb556a3333c9474b5e56e208724dd6dc7/lib/keytar.js#L36 I'm fine with it checking to avoid sending `null` or `undefined` through to the native APIs, but...

> I understand `[email protected]` is pretty old, but it should still work against the `libsecret` API, according to the documentation, right? No, the switch to using `libsecret` was added in...

@oltreseba can you confirm that the `gnome-keyring-daemon` is active? The "wait forever" behaviour makes sense if there's nothing responding to the request from keytar to set the password.

> I'm actually rather surprised that keytar works at all without `libsecret-1-dev` installed... This is a dependency for building the library, and isn't needed at runtime (i.e. in a packaged...